FLEDGE: Enable screen height as unit and pure numbers input for ad size. #39730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 27, 2023
size. Currently, for generateBid() and joinAdInterestGroup(), the supported ad size units are * "px": pixel * "sw": screen width This CL adds the unit: * "sh": screen height The parser is also updated to support parsing pure numbers as pixels. For example, "100" is parsed as 100 pixels. A regular expression is used to match the input, and capture the sub-patterns for value and unit. ^\s*((?:0|(?:[1-9][0-9]*))(?:\.[0-9]+)?)(px|sw|sh)?\s*$ It basically means we match 1. Zero or more leading spaces. 2. Numbers, with optionally decimal point and digits. No leading space, cannot begin with zero, non-negative. (Sub-pattern captured) 3. Immediately followed by an unit which can be one of "px", "sw" or "sh", or the unit can be ignored entirely. entirely. (Sub-pattern captured) 4. Zero or more trailing spaces. Bug: http://b/239866637 See Turtledove issue: WICG/turtledove#312 See Turtledove PR: WICG/turtledove#417 Change-Id: I336055ff3dd635dcdfd78999d0cb5972569f5ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402817 Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Garrett Tanzer <gtanzer@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137102}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4402817
branch
from
6ce33da
to
a3d957d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for generateBid() and joinAdInterestGroup(), the supported
ad size units are
This CL adds the unit:
The parser is also updated to support parsing pure numbers as pixels.
For example, "100" is parsed as 100 pixels.
A regular expression is used to match the input, and capture the
sub-patterns for value and unit.
^\s*((?:0|(?:[1-9][0-9]))(?:.[0-9]+)?)(px|sw|sh)?\s$
It basically means we match
entirely. (Sub-pattern captured)
Bug: http://b/239866637
See Turtledove issue: WICG/turtledove#312
See Turtledove PR: WICG/turtledove#417
Change-Id: I336055ff3dd635dcdfd78999d0cb5972569f5ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4402817
Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org>
Reviewed-by: Garrett Tanzer <gtanzer@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1137102}