Update the-input-element/selection-pointer.html to support multi-range #39753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 28, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4492089
branch
from
a600d84
to
a6b4c16
Compare
See [1] for context. This CL makes this test pass in the case that multiple range support is present *and* selecting across an `<input>` creates multiple ranges. Note that in my local testing, only a single range is created on all rendering engines (Blink, WebKit, and Gecko) when the user selects across an `<input>`. Thus, I was not able to test the newly added code here. I did attempt to verify that it would work correctly, however, and I believe it will. [1] web-platform-tests/interop#313 Change-Id: I88c88fcca47da627a0be9de518b76bbbcc07964b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4492089 Reviewed-by: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137412}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4492089
branch
from
a6b4c16
to
4b7b7db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1] for context. This CL makes this test pass in the case that
multiple range support is present and selecting across an
\<input>creates multiple ranges. Note that in my local testing, only a single
range is created on all rendering engines (Blink, WebKit, and Gecko)
when the user selects across an
\<input>. Thus, I was not able to testthe newly added code here. I did attempt to verify that it would work
correctly, however, and I believe it will.
[1] web-platform-tests/interop#313
Change-Id: I88c88fcca47da627a0be9de518b76bbbcc07964b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4492089
Reviewed-by: Di Zhang <dizhangg@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1137412}