[Gecko Bug 1833758] Add a pref not to reset max consecutive adjustment count during running APZ async scroll. #40293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng APZ async scroll. With this pref we can avoid bug 1561450 without disabling any scroll adjustments in scroll event handlers because in the specific case of the bug the scroll adjustment in question is zero length such as ``` element.style.display = "block"; element.offsetTop // flush layout element.style.display = "none"; ``` so it can be caught by our existing consecutive adjustment heuristic. Thus with the default layout.css.scroll-anchoring.max-consecutive-adjustments value, as of now it's 10, the case of bug 1561450 will stop firing scroll events after 5 (= 10/2) additional scroll event observations. Differential Revision: https://phabricator.services.mozilla.com/D178898 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1833758 gecko-commit: 4adf1e46346688c72a6dbaeb5e965cfee658401b gecko-reviewers: emilio
wpt-pr-bot
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pref we can avoid bug 1561450 without disabling any scroll adjustments
in scroll event handlers because in the specific case of the bug the scroll
adjustment in question is zero length such as
so it can be caught by our existing consecutive adjustment heuristic. Thus with
the default layout.css.scroll-anchoring.max-consecutive-adjustments value, as of
now it's 10, the case of bug 1561450 will stop firing scroll events after
5 (= 10/2) additional scroll event observations.
Differential Revision: https://phabricator.services.mozilla.com/D178898
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1833758
gecko-commit: 4adf1e46346688c72a6dbaeb5e965cfee658401b
gecko-reviewers: emilio