[EditContext] Limit to valid element types #40558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 14, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4617146
branch
from
3545d9a
to
d46086d
Compare
In w3c/edit-context#19 the Editing WG resolved that EditContext would support the same element types as shadow root, plus `<canvas>`. Update the implementation accordingly. See also the updated spec at [2]. [1] w3c/edit-context#19 [2] https://w3c.github.io/edit-context/#extensions-to-the-htmlelement-interface Bug: 999184 Change-Id: I2a8a040a279e14e9b98ece3370acdbdd8c3597ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617146 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Alex Keng <shihken@microsoft.com> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1158908}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4617146
branch
from
d46086d
to
9732aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In w3c/edit-context#19 the Editing WG
resolved that EditContext would support the same element types as
shadow root, plus
\<canvas>.Update the implementation accordingly. See also the updated
spec at [2].
[1] w3c/edit-context#19
[2] https://w3c.github.io/edit-context/#extensions-to-the-htmlelement-interface
Bug: 999184
Change-Id: I2a8a040a279e14e9b98ece3370acdbdd8c3597ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4617146
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Alex Keng <shihken@microsoft.com>
Commit-Queue: Dan Clark <daniec@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1158908}