[Gecko Bug 1786161] Support rect() function. #41169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that rect() computes to the equivalent inset() function as well. i.e. Given `rect(t r b l)`, the equivalent function is `inset(t calc(100% - r) calc(100% - b) l)`. The implementation is straightforward, and we don't have to change anything in cpp because it is always `inset()` when building the gfx::Path. The tests for clip-path will be added in the following patch. Differential Revision: https://phabricator.services.mozilla.com/D183528 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1786161 gecko-commit: 014ccd272ac61c1a3ae3de1cbd28c021f0ffe4a0 gecko-reviewers: devtools-reviewers, emilio
Also, move the interpolation of xywh() into clip-path-interpolation-xywh-rect.html. Differential Revision: https://phabricator.services.mozilla.com/D183529 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1786161 gecko-commit: fbce1db481cab432766eb9f5b0bc78c5453c3014 gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that rect() computes to the equivalent inset() function as well.
i.e. Given
rect(t r b l), the equivalent function isinset(t calc(100% - r) calc(100% - b) l).The implementation is straightforward, and we don't have to change
anything in cpp because it is always
inset()when building the gfx::Path.The tests for clip-path will be added in the following patch.
Differential Revision: https://phabricator.services.mozilla.com/D183528
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1786161
gecko-commit: 014ccd272ac61c1a3ae3de1cbd28c021f0ffe4a0
gecko-reviewers: devtools-reviewers, emilio