New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix css-nesting parsing typo #41172
Fix css-nesting parsing typo #41172
Conversation
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
I swear I made that edit already, but in any case, thanks! |
@tabatkins are the expectations here correct? At the very least this probably needs:
As otherwise the selector is invalid in non-nested contexts? But this also expects that ampersands are introduced if not there already for non-relative selectors, in some cases even for non-relative selectors, which is very weird? E.g, the test expects: Just wanted to double-check the expectations before changing behavior here... |
Also |
(If we want to do that, which per my previous comment we might not...) |
...sigh, the reason I was so confused is that I did fix a lot of these issues in #41050, but that never merged. |
Yup.
Hm, you're right, I just misinterpreted the resolution. Curiously enough, I wrote the spec correctly, matching the resolution. Both of these are fixed in #41213. |
Thanks! |
Co-authored-by: Matthieu Dubet <matthieu.dubet@gmail.com>
https://wpt.fyi/results/css/css-nesting/parsing.html?label=experimental&label=master&aligned