Fix mach test-wpt to make crash tests work
#41513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Aug 17, 2023
|
🛠 Changes from the source pull request (servo/servo#29832) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
1 similar comment
|
🛠 Changes from the source pull request (servo/servo#29832) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
servo-wpt-sync
force-pushed
the
servo_export_29832
branch
from
0dc1f77
to
17dde89
Compare
Servo's panic hook writes backtraces to stdout. This patch changes it so they are written to stderr. The crash test executor for servo in WPT grouping formatter was also not capturing the output correctly for crashtests as the log events were being aggregated based on thread name which doesn't seem to match correctly in case of crashtests. This patch also fixes the log grouping logic to be based on test name. Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
servo-wpt-sync
force-pushed
the
servo_export_29832
branch
from
17dde89
to
2ba28ed
Compare
servo-wpt-sync
merged commit 50e91f3
into
web-platform-tests:master
31 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes two issues related to crash tests:
The second commit addresses issues with generating and capturing backtrace and stderr for crash tests.
Reviewed in servo/servo#29832