Fix WPT CSS Counters style containment tests #41820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per: https://drafts.csswg.org/css-contain/#example-6932a400 and w3c/csswg-drafts#9116 counter() and counters() can cross the style containment boundary and the first counter-increment will create a counter, that will be inherited by its siblings, so class="contain" element will have a counter from its previous sibling, and counters() inside the style containment scopes will have access to this counter. Bug: 990657 Change-Id: I9ff784577d37b7a936e96a21548006b8b0d7848d
wpt-pr-bot
approved these changes
Sep 5, 2023
tabatkins
approved these changes
Sep 29, 2023
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Oct 2, 2023
This is a dummy PR for the Chromium WPT importer to recognize web-platform-tests#41820 as an exported Chromium commit. The importer doesn't see `Change-Id` in the upstream WPT commit message, so it tries to apply the patch again, even though it's already merged. Change-Id: I9ff784577d37b7a936e96a21548006b8b0d7848d
Lightning00Blade
pushed a commit
to Lightning00Blade/wpt
that referenced
this pull request
Dec 11, 2023
Co-authored-by: Daniil Sakhapov <sakhapov@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per:
https://drafts.csswg.org/css-contain/#example-6932a400
and
w3c/csswg-drafts#9116
counter() and counters() can cross the style containment boundary
and the first counter-increment will create a counter, that will be
inherited by its siblings, so class="contain" element will have a
counter from its previous sibling, and counters() inside
the style containment scopes will have access to this counter.
Bug: 990657
Reviewed-on: https://chromium-review.googlesource.com/4839207
WPT-Export-Revision: 4ead277cddb50a1adb53cb4b5d76046d1d7bcde9