[Gecko Bug 1834641] Fix the serialization of mask shorthand property. #42181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. We should omit `mask-image` if it is the initial value and there are any other properties which are not initial values. 2. We should omit `mask-origin` if it is the initial value. 3. Tweak the order of `<masking-mode>`, which should be the last one per spec. Differential Revision: https://phabricator.services.mozilla.com/D188545 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1834641 gecko-commit: 081d116d10f850a6b4a71c5f598373a388dd0feb gecko-reviewers: emilio
wpt-pr-bot
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mask-imageif it is the initial value and there areany other properties which are not initial values.
mask-originif it is the initial value.<masking-mode>, which should be the last one per spec.Differential Revision: https://phabricator.services.mozilla.com/D188545
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1834641
gecko-commit: 081d116d10f850a6b4a71c5f598373a388dd0feb
gecko-reviewers: emilio