Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for fullscreenchange and fullscreenerror event timing #4303

Merged
merged 1 commit into from
Dec 8, 2016

Commits on Dec 8, 2016

  1. Add tests for fullscreenchange and fullscreenerror event timing

    Although HTML does not yet define animation frame tasks as used by
    Fullscreen, it does have "run the fullscreen rendering steps". That's
    the old hook, making the timing of these events relative to resize and
    animation frame callbacks unambiguous:
    https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen
    https://html.spec.whatwg.org/multipage/webappapis.html#event-loop-processing-model
    
    Spec issue: whatwg/html#707
    
    document-exit-fullscreen-timing-manual.html consistently matches
    -expected.txt, with (accidentally) correct timing but no resize event.
    
    element-request-fullscreen-timing-manual.html usually matches
    -expected.txt, with incorrect timing, but can accidentally get the
    timing right and instead fail due to no resize event.
    
    Both are marked as flaky to be safe, and will be enabled in a coming CL.
    
    Note: This CL is also a test for the WPT export process.
    
    Firefox passes both fullscreechange event tests, but fails the
    fullscreenerror test. (Implementation preceded spec changes.)
    
    BUG=402376,672436
    
    Review-Url: https://codereview.chromium.org/2564543002
    Cr-Commit-Position: refs/heads/master@{#437283}
    jeffcarp committed Dec 8, 2016
    Configuration menu
    Copy the full SHA
    1489fe9 View commit details
    Browse the repository at this point in the history