DOM: Introduce Subscriber#active attribute #43119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 13, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5017505
branch
from
1ac571e
to
66b5765
Compare
This CL introduces an API, namely `subscriber.active` for determining the activity of an existing subscription. The `active` attribute gets set to false by the platform synchronously before the Observer's completion and error handlers are invoked. This has the effect of being observably `false` _within_ those handlers, unlike `subscriber.signal.aborted`. Please see the lengthy design notes in both WICG/observable#76 and WICG/observable#82. R=masonf@chromium.org For WPTs: Co-authored-by: ben@benlesh.com Bug: 1485981 Change-Id: I4604a80347ff30ff7be44a131bfdd3999b71252a
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5017505
branch
from
66b5765
to
b9ffa70
Compare
|
Superseded by #43159. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces an API, namely
subscriber.activefor determiningthe activity of an existing subscription. The
activeattribute getsset to false by the platform synchronously before the Observer's
completion and error handlers are invoked. This has the effect of being
observably
falsewithin those handlers, unlikesubscriber.signal.aborted. Please see the lengthy design notes in bothWICG/observable#76 and
WICG/observable#82.
R=masonf@chromium.org
For WPTs:
Co-authored-by: ben@benlesh.com
Bug: 1485981
Reviewed-on: https://chromium-review.googlesource.com/5017505
WPT-Export-Revision: 60d5b3d34ccc1ed64c2a2116b5787586022d6d00