[Gecko Bug 1864647] Don't crash when finding nested relative selectors. #43186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, do the same as pseudo-elements, which is effectively to keep them in the replaced selector but don't match them. Avoid crashing in this case. I filed w3c/csswg-drafts#9600 since this issue isn't specific about :has(), and depending on the result of that discussion, the "proper" solution might be different. Differential Revision: https://phabricator.services.mozilla.com/D193663 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1864647 gecko-commit: 69bede2c30ec37c0a9b3b44879e28a5dd1c0b1c5 gecko-reviewers: dshin
wpt-pr-bot
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, do the same as pseudo-elements, which is effectively to keep
them in the replaced selector but don't match them. Avoid crashing in
this case.
I filed w3c/csswg-drafts#9600 since this issue
isn't specific about :has(), and depending on the result of that
discussion, the "proper" solution might be different.
Differential Revision: https://phabricator.services.mozilla.com/D193663
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1864647
gecko-commit: 69bede2c30ec37c0a9b3b44879e28a5dd1c0b1c5
gecko-reviewers: dshin