[Gecko Bug 1865618] [wdspec] Rename test module set_viewport.py to viewport.py. #43342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: https://phabricator.services.mozilla.com/D194544 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1865618 gecko-commit: 65228ad8a272389c4048f39b7d468b19a284e3b3 gecko-reviewers: webdriver-reviewers, Sasha
…cePixelRatio" tests. Tests were not failing as expected because of the missing "viewport" argument. Differential Revision: https://phabricator.services.mozilla.com/D194545 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1865618 gecko-commit: a9f154bc28c739143d8d3226aa305bf6cc184566 gecko-reviewers: webdriver-reviewers, Sasha
Without an actual page loaded, changing the viewport will not trigger any reflow and as such doesn't test real use-case scenarios. Differential Revision: https://phabricator.services.mozilla.com/D194624 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1865618 gecko-commit: 988211aadb0d43726c920e868dfa7dd055f7fa77 gecko-reviewers: webdriver-reviewers, Sasha
wpt-pr-bot
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: https://phabricator.services.mozilla.com/D194544
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1865618
gecko-commit: 65228ad8a272389c4048f39b7d468b19a284e3b3
gecko-reviewers: webdriver-reviewers, Sasha