Allow calc() values in xywh/rect #43815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 28, 2023
This patch fixes two checks that are hit when using calc() in xywh/rect values: 1. We cannot check for non-negative calc expressions at parse time in the general case (see: `GetDoubleValue()` in css_primitive_value.h), so this patch makes the DCHECK only apply to numeric literals. 2. Similar to CalculationValue::SubtractFromOneHundredPercent, we cannot guarantee ranges in CalculationValue::Add. This is used when computing the inset value of xywh/rect (see: https://drafts.csswg.org/css-shapes/#basic-shape-computed-values), where the w and h values are non-negative, but the x and y values can be anything. Bug: 1513647 Change-Id: I8ddf85711d1c3d6a698b6ff174770864e3b776bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5155165 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1241921}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5155165
branch
from
3c607ae
to
21bfc03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes two checks that are hit when using calc() in xywh/rect
values:
the general case (see:
GetDoubleValue()in css_primitive_value.h),so this patch makes the DCHECK only apply to numeric literals.
cannot guarantee ranges in CalculationValue::Add. This is used when
computing the inset value of xywh/rect (see:
https://drafts.csswg.org/css-shapes/#basic-shape-computed-values),
where the w and h values are non-negative, but the x and y values
can be anything.
Bug: 1513647
Change-Id: I8ddf85711d1c3d6a698b6ff174770864e3b776bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5155165
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1241921}