[css-color-5] channel values of relative color syntax are numbers #43931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2024
Closed
svgeesus
approved these changes
Jan 11, 2024
romainmenke
deleted the
css-color-5-relative-color-values-are-numbers--rational-axolotl-43ece2560a
branch
marcoscaceres
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone over the existing tests as well as I could and I couldn't spot any that used
+or-. As far as I know using addition or subtraction is the simplest way to test that channel values are numbers and not something else. Because1 + 1%and1 + 1degis expected to fail whereas1% * 2is valid CSS.So I've added a few test cases for each notation that includes a calc on a channel keyword with a
+.I've also added some invalid test cases where I do the inverse, test for
+ 1%and where relevant+ 1deg.