Consolidate pointer attribute testing #44147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5229777
branch
8 times, most recently
from
77cc399
to
ba21119
Compare
The primary goal of this patch was to address memory leaks. These leaks were likely due to pending promises at the completion of the test. The 3 tests for hover pointers, non-hover pointers and hover with right click were all very similar in structure and were consolidated in the patch. We now have 5 variants instead of 3 separate tests. In the process the tests were modernized to be promise tests instead of an async test. The structure was reformatted to remove the manual test feel. Bug: 1430360, 1499775, 1446799 Change-Id: Ia6dc48405d2e2197e3c020fdb803d836043698f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5229777 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1252074}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5229777
branch
from
ba21119
to
446f853
Compare
wpt-pr-bot
approved these changes
Jan 25, 2024
This was referenced Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this patch was to address memory leaks. These
leaks were likely due to pending promises at the completion of the test.
The 3 tests for hover pointers, non-hover pointers and hover with
right click were all very similar in structure and were consolidated
in the patch. We now have 5 variants instead of 3 separate tests.
In the process the tests were modernized to be promise tests instead
of an async test. The structure was reformatted to remove the manual
test feel.
Bug: 1430360, 1499775, 1446799
Change-Id: Ia6dc48405d2e2197e3c020fdb803d836043698f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5229777
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252074}