getComputedStyle() for pseudo-elements with argument #44607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamr
reviewed
Feb 16, 2024
noamr
reviewed
Feb 16, 2024
noamr
approved these changes
Feb 16, 2024
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Feb 16, 2024
…:highlight() https://bugs.webkit.org/show_bug.cgi?id=264103 rdar://117864743 Reviewed by Antti Koivisto. This adds parsing support for pseudo-elements with an argument to CSSSelector::parsePseudoElement(). For now only getComputedStyle() makes use of it and other callers continue to treat pseudo-elements with an argument as an error. To avoid hitting an assert introduced by 274629@main and also problems found in debugging where a RenderStyle's pseudoElementNameArgument would get overwritten this makes MatchedDeclarationsCache::isCacheable() return false when there is such an argument. New tests are upstreamed here: web-platform-tests/wpt#44607 * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-008-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-elements-013-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-highlight-api/highlight-pseudo-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-currentcolor-computed-visited-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-computed-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-inheritance-computed-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/highlight-pseudos-visited-computed-001-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/mix-blend-mode-only-on-transition-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/style-inheritance-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-with-argument-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-with-argument.html: Added. * LayoutTests/imported/w3c/web-platform-tests/css/cssom/w3c-import.log: * Source/WebCore/animation/WebAnimationUtilities.cpp: (WebCore::pseudoIdFromString): * Source/WebCore/css/CSSSelector.cpp: (WebCore::pseudoElementIdentifierFor): (WebCore::CSSSelector::parsePseudoElement): * Source/WebCore/css/CSSSelector.h: * Source/WebCore/page/LocalDOMWindow.cpp: (WebCore::LocalDOMWindow::getComputedStyle const): (WebCore::LocalDOMWindow::getMatchedCSSRules const): * Source/WebCore/style/MatchedDeclarationsCache.cpp: (WebCore::Style::MatchedDeclarationsCache::isCacheable): Canonical link: https://commits.webkit.org/274846@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.