a11y: test empty string fallback for CSS content property #44971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
cookiecrook,
jnurthen,
MelSumner and
spectranaut
webkit-commit-queue
pushed a commit
to annevk/WebKit
that referenced
this pull request
Mar 9, 2024
…y string https://bugs.webkit.org/show_bug.cgi?id=270377 rdar://123919677 Reviewed by Antoine Quint. This issue came to light as part of the <input type=checkbox switch> demo, but is more universally applicable as shown in the tests. While here, also cleanup some of the code as the render objects involved cannot become null. New web-platform-tests tests are exported: web-platform-tests/wpt#44971 * LayoutTests/accessibility/mac/alt-for-css-content-expected.txt: * LayoutTests/accessibility/mac/alt-for-css-content.html: * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/accname/name/comp_name_from_content.html: * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::textUnderElement const): Canonical link: https://commits.webkit.org/275872@main
foolip
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.