Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix permissions-policy-payment-extension.html to only check error name #45455

Merged
merged 2 commits into from
May 16, 2024
Merged

fix permissions-policy-payment-extension.html to only check error name #45455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2925ba2
fix permissions-policy-payment-extension.html to only check error name
marcoscaceres Apr 1, 2024
c473238
Update payment-extension-allowed-by-permissions-policy-attribute.http…
marcoscaceres Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions permissions-policy/payment-extension-allowed-by-permissions-policy-attribute.https.sub.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,12 @@
var same_origin_src = '/permissions-policy/resources/permissions-policy-payment-extension.html';
var cross_origin_src = 'https://{{domains[www]}}:{{ports[https][0]}}' +
same_origin_src;
var feature_name = 'permissions policy "payment"';
var feature_name = 'WebAuthn "payment" extension';
var header = 'allow="payment" attribute';

promise_test(t => {
return test_feature_availability_with_post_message_result(
t, cross_origin_src, "NotSupportedError#The 'payment' or 'publickey-credentials-create' features are not " +
"enabled in this document. Permissions Policy may be used to " +
"delegate Web Payment capabilities to cross-origin child frames.");
t, cross_origin_src, "NotSupportedError");
}, feature_name + ' is not supported in cross-origin iframe without ' + header);
marcoscaceres marked this conversation as resolved.
Show resolved Hide resolved

promise_test(t => {
Expand Down
2 changes: 1 addition & 1 deletion permissions-policy/resources/permissions-policy-payment-extension.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
});
} catch (e) {
enabled = false;
name = e.name + '#' + e.message;
name = e.name;
}
parent.postMessage({ type: 'availability-result', enabled, name }, '*');
}
Expand Down