Revert "[css-anchor-position] Create scroll node for scrolled overflow:hidden" #46071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w:hidden" This reverts commit ab59a9730332d45a95f6ba6f6e27bd967fcd3874. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5662675260407808 Sample build with failed test: https://ci.chromium.org/b/8748905765807722673 Affected test(s): [ninja://:blink_wpt_tests/external/wpt/html/semantics/forms/the-selectlist-element/selectlist-option-arbitrary-content-displayed.tentative.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_wpt_tests%2Fexternal%2Fwpt%2Fhtml%2Fsemantics%2Fforms%2Fthe-selectlist-element%2Fselectlist-option-arbitrary-content-displayed.tentative.html?q=VHash%3Aee7ed2231ecfebc6) [ninja://:blink_wpt_tests/virtual/stylable-select-disabled/external/wpt/html/semantics/forms/the-selectlist-element/selectlist-option-arbitrary-content-displayed.tentative.html](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2F:blink_wpt_tests%2Fvirtual%2Fstylable-select-disabled%2Fexternal%2Fwpt%2Fhtml%2Fsemantics%2Fforms%2Fthe-selectlist-element%2Fselectlist-option-arbitrary-content-displayed.tentative.html?q=VHash%3Aee7ed2231ecfebc6) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5662675260407808&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5503383&type=BUG Original change's description: > [css-anchor-position] Create scroll node for scrolled overflow:hidden > > This makes sure cc::TransformTree::AnchorPositionOffset can get the > scroll offset of scrolled overflow:hidden adjustment containers. > > Bug: 332331854 > Change-Id: Ib3c0c49af5746714c94a03e0ae25574df3b50f91 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503383 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1296415} > Bug: 332331854 Change-Id: I2f331b5aa4dce0406bd4e830c896312a8bd200df No-Presubmit: true No-Tree-Checks: true No-Try: true
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ab59a9730332d45a95f6ba6f6e27bd967fcd3874.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5662675260407808
Sample build with failed test: https://ci.chromium.org/b/8748905765807722673
Affected test(s):
ninja://:blink_wpt_tests/external/wpt/html/semantics/forms/the-selectlist-element/selectlist-option-arbitrary-content-displayed.tentative.html
ninja://:blink_wpt_tests/virtual/stylable-select-disabled/external/wpt/html/semantics/forms/the-selectlist-element/selectlist-option-arbitrary-content-displayed.tentative.html
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5662675260407808&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5503383&type=BUG
Original change's description:
Bug: 332331854
Change-Id: I2f331b5aa4dce0406bd4e830c896312a8bd200df
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/5513691
WPT-Export-Revision: 19a79910916e6bdc93eca618e3c8c79187752259