Use compression-dictionary for link rel attribute
#46386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5550240
branch
from
ebc01d7
to
9539364
Compare
Currently Chromium is using `dictionary` link rel attribute for fetching compression dictionaries. But in the new spec of Compression Dictionary Transport [1], `compression-dictionary` is used for link rel attribute. So this CL changes the Chromium code to use `compression-dictionary` for link rel attribute. Note: This change is a breaking change. But this feature is not enabled by default yet, and we are not conducting Origin Trial experiment now. [1] https://datatracker.ietf.org/doc/draft-ietf-httpbis-compression-dictionary/04/ Bug: 40255884 Change-Id: Ie393e22c6b7411568406c55c7b16516f70040dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550240 Reviewed-by: Patrick Meenan <pmeenan@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1303739}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5550240
branch
from
9539364
to
ef39aeb
Compare
wpt-pr-bot
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Chromium is using
dictionarylink rel attribute for fetchingcompression dictionaries. But in the new spec of Compression Dictionary
Transport [1],
compression-dictionaryis used for link rel attribute.So this CL changes the Chromium code to use
compression-dictionaryforlink rel attribute.
Note: This change is a breaking change. But this feature is not enabled
by default yet, and we are not conducting Origin Trial experiment now.
[1] https://datatracker.ietf.org/doc/draft-ietf-httpbis-compression-dictionary/04/
Bug: 40255884
Change-Id: Ie393e22c6b7411568406c55c7b16516f70040dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5550240
Reviewed-by: Patrick Meenan <pmeenan@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1303739}