[PEPC] Clamp min-width/height based on the maximum allowed value as well #46477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5563906
branch
from
6a8141a
to
0d5c914
Compare
The min/max-width/height properties for the permission element are bounded in an effort to prevent the width/height from going above/below certain hard-set limits. However the min-width/height will overrule the max-width/height if it's bigger. This means that the current restrictions can be bypassed in one direction by setting the min-width/height to very large values, as they are currently only lower bounded (restricted from being too small). This CL instead changes the logic to clamp the min-width/height so that it also has an upper bound. Fixed: 341947676 Change-Id: I6fe68b6d9f07e4041e5c4455fc34dce167b01be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5563906 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1305710}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5563906
branch
from
0d5c914
to
ecfbe56
Compare
wpt-pr-bot
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min/max-width/height properties for the permission element are
bounded in an effort to prevent the width/height from going above/below
certain hard-set limits. However the min-width/height will overrule
the max-width/height if it's bigger. This means that the current
restrictions can be bypassed in one direction by setting the
min-width/height to very large values, as they are currently only lower
bounded (restricted from being too small). This CL instead changes the
logic to clamp the min-width/height so that it also has an upper bound.
Fixed: 341947676
Change-Id: I6fe68b6d9f07e4041e5c4455fc34dce167b01be5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5563906
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1305710}