Clean up anchor attribute display test and test for auto value
#46514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test did not exercise the `auto` keyword within the anchor() function. The new test ensures `auto` can be used as a value for `position-anchor` but not as a first argument to the `anchor()` function. The spec is here: https://drafts.csswg.org/css-anchor-position-1/#anchor-pos Bug: 342579983 Change-Id: I4a2c953496bdbb650db54dcc3e0b8595046f3de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569991 Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1306864}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5569991
branch
from
777f37b
to
7d250ef
Compare
wpt-pr-bot
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test did not exercise the
autokeyword within theanchor() function. The new test ensures
autocan be used as avalue for
position-anchorbut not as a first argument to theanchor()function.The spec is here:
https://drafts.csswg.org/css-anchor-position-1/#anchor-pos
Bug: 342579983
Change-Id: I4a2c953496bdbb650db54dcc3e0b8595046f3de6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569991
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306864}