Referenced SVG elements in an external resource document match :target #46545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Track which elements are referenced (by <use>) in an external resource document by funneling the lookup through a special function on SVGResourceDocumentContent that creates SVGResourceTarget objects for each (valid) reference and lets the targeted element weakly reference the object. While matching :target, the selector checker will check if the element has a reference to an SVGResourceTarget object and let :target match if it does. Bug: 342705674 Change-Id: I9b88e4338dccc0e01c45afb0df3e1c412b2466a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5574989 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1307926}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5574989
branch
from
ed0088b
to
319b57c
Compare
wpt-pr-bot
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track which elements are referenced (by <use>) in an external resource
document by funneling the lookup through a special function on
SVGResourceDocumentContent that creates SVGResourceTarget objects for
each (valid) reference and lets the targeted element weakly reference
the object. While matching :target, the selector checker will check if
the element has a reference to an SVGResourceTarget object and let
:target match if it does.
Bug: 342705674
Change-Id: I9b88e4338dccc0e01c45afb0df3e1c412b2466a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5574989
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1307926}