webnn: Immediately copy constant data #46883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the data of ArrayBufferViews passed to the constant() method is copied during the build() method. This does not match the spec: https://www.w3.org/TR/webnn/#dom-mlgraphbuilder-constant Cq-Include-Trybots: luci.chromium.try:win11-blink-rel Bug: 348598508 Change-Id: Ief7a686324375fb2027df8a30d2c97943149bbe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649032 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Austin Sullivan <asully@chromium.org> Auto-Submit: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1318727}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5649032
branch
from
013a065
to
1c74033
Compare
wpt-pr-bot
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the data of ArrayBufferViews passed to the constant() method
is copied during the build() method. This does not match the spec:
https://www.w3.org/TR/webnn/#dom-mlgraphbuilder-constant
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel
Bug: 348598508
Change-Id: Ief7a686324375fb2027df8a30d2c97943149bbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5649032
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Austin Sullivan <asully@chromium.org>
Auto-Submit: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1318727}