Test that window.customElements is per global, not per-document #5681
Conversation
|
Notifying @alsemenov, @deepak-sa, @dominiccooney, @hayatoito, @kojiishi, @rniwa, @sgrekhov, and @TakayoshiKochi. (Learn how reviewing works.) |
LintPassed |
Firefox (nightly channel)Testing web-platform-tests at revision d547f34 All results1 test ran/custom-elements/custom-element-registry/per-global.html
|
Chrome (unstable channel)Testing web-platform-tests at revision d547f34 All results1 test ran/custom-elements/custom-element-registry/per-global.html
|
|
|
||
| const after = frame[propertyName]; | ||
| assert_equals(after, before); | ||
| t.done(); |
There was a problem hiding this comment.
Cannot be used here because we don't want to be done if the location is about:blank. I'll add a comment.
common/object-association.js
Outdated
|
|
||
| const after = frame[propertyName]; | ||
| assert_not_equals(after, before); | ||
| t.done(); |
|
|
||
| iframe.src = "/common/blank.html"; | ||
| document.body.appendChild(iframe); | ||
| }, `document.open() must replace window.${propertyName}`); |
There was a problem hiding this comment.
This is disputed: whatwg/html#1698. Not sure if we should test it. We should maybe call this out as an open issue in the HTML Standard.
There was a problem hiding this comment.
My take is that even if we change the spec there we'll still want to reset all the per-Window objects. I'll comment there.
| <link rel="author" title="Domenic Denicola" href="mailto:d@domenic.me"> | ||
| <script src="/common/object-association.js"></script> | ||
|
|
||
| <iframe id="blank-iframe"></iframe> |
There was a problem hiding this comment.
It seems you can remove this. Meaning this could in fact be a .window.js though that would remove some metadata so up to you.
|
Let's merge this and file bugs, and if people object we can reopen discussion. It seems like the right way to get the conversation started. |
See whatwg/html#2578.
/cc @rniwa @dominiccooney
This change is