New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTCPeerConnection IDL test to latest editor draft #5693
Update RTCPeerConnection IDL test to latest editor draft #5693
Conversation
Move the test file to root webrtc/ directory following new naming convention.
Notifying @agouaillard, @alvestrand, @dontcallmedom, and @phoglund. (Learn how reviewing works.) |
LintPassed |
Firefox (nightly channel)Testing web-platform-tests at revision d063fcc All results1 test ran/webrtc/RTCPeerConnection-idl.html
|
Chrome (unstable channel)Testing web-platform-tests at revision d063fcc All results1 test ran/webrtc/RTCPeerConnection-idl.html
|
In #5666 @ayg has begun splitting out IDL files into interfaces/*.idl, which I think will be a big improvement and could make it much easier to maintain these tests. So, I would actually suggest a single interfaces/webrtc-pc.idl that contains all of the IDL in https://w3c.github.io/webrtc-pc/, and a single webrtc/interfaces.html that tests all of that. I think it's still small enough that timeouts wouldn't be a problem. |
+1 sounds good. I will submit a separate PR replacing this and the other IDL PRs I submitted. |
ok, when you have the new PR in place, let me know, we will reference it in here for traceability, and close this one. |
Closed the others, leaving this one open until the replacement is in. |
Closing in favor of #5712 even though it's still open. |
This PR updates the RTCPeerConnection IDL test to the latest editor draft. The test file is also moved to root webrtc/ directory following new naming convention in accordance to #5657.
This change is