Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-ui-3] Mark support for non fixed size svg as optional #7430

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

frivoal
Copy link
Contributor

@frivoal frivoal commented Sep 21, 2017

This is to match the following spec change: w3c/csswg-drafts@5dcad30

@w3c-bots
Copy link

w3c-bots commented Sep 21, 2017

Build PASSED

Started: 2017-09-21 03:00:30
Finished: 2017-09-21 03:06:49

View more information about this build on:

Copy link
Contributor

@AmeliaBR AmeliaBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the test is testing whether an SVG image without intrinsic size is accepted as a valid cursor, and that the CSS WG agreed to make that a "may" option.

Based on the definitions of the WPT/CSS metadata flags, the change to the <meta> tag therefore seems to be correct.

I can also confirm that it it very disappointing that browsers all fail this test. That sheep would make a very cute cursor.

@frivoal
Copy link
Contributor Author

frivoal commented Sep 21, 2017

@plehegar @gsnedders @plinss Can one of you make @AmeliaBR an approved reviewer?

@gsnedders gsnedders merged commit 92770f6 into web-platform-tests:master Sep 21, 2017
@frivoal frivoal deleted the svg-nfs-may branch September 21, 2017 07:13
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
jakearchibald pushed a commit to jakearchibald/web-platform-tests that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants