Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Scheme] Remove isProtocolHandlerRegistered in the NavigatorContentUtils of blink #8431

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Nov 24, 2017

isProtocolHandlerRegistered has been existed in blink. However, latest custom scheme whatwg
specfication removed it.

The reason to remove it was that no browsers have supported the function. So it would be good
if we remove it from blink in order to reduce our maintanance overhead.

Bug: 121825
Change-Id: I3e99dd5996e55dedcd8b5d47a7103410acfd24eb
Reviewed-on: https://chromium-review.googlesource.com/784653
Commit-Queue: Gyuyoung Kim gyuyoung.kim@lge.com
Reviewed-by: Mike Lawther mikelawther@chromium.org
Reviewed-by: Kentaro Hara haraken@chromium.org
Cr-Commit-Position: refs/heads/master@{#518981}


This change is Reviewable

…ntentUtils of blink

isProtocolHandlerRegistered has been existed in blink. However, latest custom scheme whatwg
specfication removed it.

- whatwg: https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
- whatwg issue: whatwg/html#630
- commit to remove it: whatwg/html@b143dbc

The reason to remove it was that no browsers have supported the function. So it would be good
if we remove it from blink in order to reduce our maintanance overhead.

Bug: 121825
Change-Id: I3e99dd5996e55dedcd8b5d47a7103410acfd24eb
Reviewed-on: https://chromium-review.googlesource.com/784653
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Reviewed-by: Mike Lawther <mikelawther@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518981}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@w3c-bots
Copy link

w3c-bots commented Nov 24, 2017

Build PASSED

Started: 2017-11-24 18:32:11
Finished: 2017-11-24 18:41:06

View more information about this build on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants