Tests for PaymentItem.type member #9099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
AmazingJaze,
domenic,
edenchuang,
jensl,
MSFTkihans,
rsolomakhin and
yuki3
Build PASSEDStarted: 2018-03-22 04:50:24 View more information about this build on: |
This reverts commit c30bec2. We reveted this in the spec also.
marcoscaceres
force-pushed
the
displayItem_type_member
branch
from
6ae69b4
to
fe3f4cb
Compare
|
|
||
| test(() => { | ||
| // Let's make an invalid DisplayItem to add to displayItems | ||
| const invalidDisplayItem = { ...validDisplayItem, type: "this is not valid" }; |
There was a problem hiding this comment.
Since Edge doesn't support object spreading I guess this should change along with the other places?
There was a problem hiding this comment.
yeah :( There are a few others that will need the same treatment. ITS IE6 ALL OVER AGAIN! 🤣
marcoscaceres
force-pushed
the
displayItem_type_member
branch
from
76bf5e7
to
207682a
Compare
mnoorenberghe
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for w3c/payment-request#666