Add Proximity Sensor tests and delete outdated tests #9131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
alexshalamov,
dontcallmedom,
Honry,
pozdnyakov,
riju and
zqzhang
Build PASSEDStarted: 2018-01-23 05:59:51 View more information about this build on: |
Honry
reviewed
Jan 23, 2018
| @@ -10,7 +10,8 @@ const properties = { | |||
| 'AbsoluteOrientationSensor' : ['timestamp', 'quaternion'], | |||
| 'RelativeOrientationSensor' : ['timestamp', 'quaternion'], | |||
| 'GeolocationSensor' : ['timestamp', 'latitude', 'longitude', 'altitude', | |||
| 'accuracy', 'altitudeAccuracy', 'heading', 'speed'] | |||
| 'accuracy', 'altitudeAccuracy', 'heading', 'speed'], | |||
| 'ProximitySensor' : ['timestamp', 'max'] | |||
There was a problem hiding this comment.
Did you miss the distance and near attribute?
There was a problem hiding this comment.
If the physical object is outside the sensing range, the attribute distance and near must return null, it conflicts the common function assert_reading_not_null, so I will add tests for them separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.