Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proximity Sensor tests and delete outdated tests #9131

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
4 participants
@kaixinjxq
Copy link
Contributor

kaixinjxq commented Jan 23, 2018

No description provided.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Jan 23, 2018

Build PASSED

Started: 2018-01-23 05:59:51
Finished: 2018-01-23 06:10:45

View more information about this build on:

@@ -10,7 +10,8 @@ const properties = {
'AbsoluteOrientationSensor' : ['timestamp', 'quaternion'],
'RelativeOrientationSensor' : ['timestamp', 'quaternion'],
'GeolocationSensor' : ['timestamp', 'latitude', 'longitude', 'altitude',
'accuracy', 'altitudeAccuracy', 'heading', 'speed']
'accuracy', 'altitudeAccuracy', 'heading', 'speed'],
'ProximitySensor' : ['timestamp', 'max']

This comment has been minimized.

Copy link
@Honry

Honry Jan 23, 2018

Contributor

Did you miss the distance and near attribute?

This comment has been minimized.

Copy link
@kaixinjxq

kaixinjxq Jan 23, 2018

Author Contributor

If the physical object is outside the sensing range, the attribute distance and near must return null, it conflicts the common function assert_reading_not_null, so I will add tests for them separately.

@Honry

Honry approved these changes Jan 23, 2018

Copy link
Contributor

Honry left a comment

Thanks, LGTM

@Honry Honry merged commit 14017b1 into web-platform-tests:master Jan 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kaixinjxq kaixinjxq deleted the kaixinjxq:proximity_common branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.