Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-typed-om] CSSUnitValue.unit should be readonly #9366

Merged
merged 1 commit into from Feb 3, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Feb 2, 2018

CSSUnitValue.unit should be immutable to prevent cyclic references

Bug: 803687
Change-Id: I35f79ec2491277fcb2d02ce85a2e9c6ecd8c3a07
Reviewed-on: https://chromium-review.googlesource.com/897177
Reviewed-by: Darren Shen shend@chromium.org
Commit-Queue: Hwanseung Lee hs1217.lee@samsung.com
Cr-Commit-Position: refs/heads/master@{#534237}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Feb 2, 2018

Build PASSED

Started: 2018-02-03 02:15:53
Finished: 2018-02-03 02:23:15

View more information about this build on:

[css-typed-om] CSSUnitValue.unit should be readonly
CSSUnitValue.unit should be immutable to prevent cyclic references

Bug: 803687
Change-Id: I35f79ec2491277fcb2d02ce85a2e9c6ecd8c3a07
Reviewed-on: https://chromium-review.googlesource.com/897177
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#534237}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-897177 branch from 0fecc3b to 0c67ec2 Feb 3, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 1410cfb into master Feb 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-897177 branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.