Don't pixel-snap the top and bottom of lines. #9923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 8, 2018
Build PASSEDStarted: 2018-03-09 11:58:54 Failing Jobs
View more information about this build on: |
That might cause incorrect detection of overflow, since the height of the block isn't pixel-snapped. Bug: 818873 Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0 Reviewed-on: https://chromium-review.googlesource.com/954022 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#542080}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-954022
branch
from
fd1fe11
to
b78fcad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That might cause incorrect detection of overflow, since the height of
the block isn't pixel-snapped.
Bug: 818873
Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0
Reviewed-on: https://chromium-review.googlesource.com/954022
Reviewed-by: Emil A Eklund eae@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#542080}