Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pixel-snap the top and bottom of lines. #9923

Merged
merged 1 commit into from Mar 9, 2018

Conversation

Projects
None yet
4 participants
@chromium-wpt-export-bot
Copy link
Collaborator

chromium-wpt-export-bot commented Mar 8, 2018

That might cause incorrect detection of overflow, since the height of
the block isn't pixel-snapped.

Bug: 818873
Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0
Reviewed-on: https://chromium-review.googlesource.com/954022
Reviewed-by: Emil A Eklund eae@chromium.org
Commit-Queue: Morten Stenshorne mstensho@chromium.org
Cr-Commit-Position: refs/heads/master@{#542080}

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot left a comment

Already reviewed downstream.

@w3c-bots

This comment has been minimized.

Copy link

w3c-bots commented Mar 8, 2018

Build PASSED

Started: 2018-03-09 11:58:54
Finished: 2018-03-09 12:03:24

Failing Jobs

  • safari:11.0
  • MicrosoftEdge:16.16299

View more information about this build on:

Don't pixel-snap the top and bottom of lines.
That might cause incorrect detection of overflow, since the height of
the block isn't pixel-snapped.

Bug: 818873
Change-Id: I864be9dfedf6f008fe19ce02088ac6488ec274d0
Reviewed-on: https://chromium-review.googlesource.com/954022
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542080}

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-954022 branch from fd1fe11 to b78fcad Mar 9, 2018

@chromium-wpt-export-bot chromium-wpt-export-bot merged commit 6cca524 into master Mar 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-954022 branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.