Target for net47 + removed dependency on external Http package #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, That's awesome work - thank you. Sorry for my late response, i've been quite busy with moving and new job. I'll try and get a new nuget build up asap. Kind Regards, |
|
Hey @coryjthompson, thanks for merging. Did you have time to push it to the nuget server yet? That would make my CI developer happy, then he can remove one extra repository from his build script :) |
|
Hi @nielsvoigt, I'm looking to push to nuget today. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @coryjthompson,
Great package, I'm looking forward to using it!
I had to use it in a .NET 4.7 library and noticed that
System.Net.Httpis available there natively. So I removed the package reference toMicrosoft.Net.Httpfrom the .NET Framework 4.5, 4.6 and 4.7 configurations (added 4.7).I updated Newtonsoft Json and added an
InternalsVisibleAttribute since your changing of the access modifiers of the utils broke the tests.I also raised the version so my nuget would pick it up as an update.
Related StackOverflow Question