Adding a date range opacity prop for light mode #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crussell122 Hey thanks for your commit! I was busy lately so haven't seen in yet. I would rather follow specifications of Material Design on this or do other opacities for light/dark mode. Is it ugly in your app? We need to check with the color library if the color is dark and use other colors I think |
|
Let's close this. The user that opened this was helping out on my side project and this is no longer relevant. We should just follow Material guidelines as you've mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #85, added an optional rangeOpacity prop to allow for different opacity levels for light mode.
p.s. This is my first time ever contributing to an open source project so feedback is welcomed!