Skip to content

Commit

Permalink
Add bbc-sounds connector
Browse files Browse the repository at this point in the history
Closes #1922.
  • Loading branch information
alexesprit committed Jun 12, 2019
1 parent 579acb7 commit 832ec5a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/connectors/bbc-sounds.js
@@ -0,0 +1,13 @@
'use strict';

Connector.playerSelector = '.radio-main';

Connector.artistSelector = '.sc-c-track__artist';

Connector.trackSelector = '.sc-c-track__title';

// TODO: remove these functions

Connector.getArtist = () => $(Connector.artistSelector).first().text();

Connector.getTrack = () => $(Connector.trackSelector).first().text();
4 changes: 4 additions & 0 deletions src/core/connectors.js
Expand Up @@ -166,6 +166,10 @@ define(function() {
label: 'BBC RadioPlayer',
matches: ['*://www.bbc.co.uk/radio/player/*'],
js: ['connectors/bbcradioplayer.js'],
}, {
label: 'BBC Sounds',
matches: ['*://www.bbc.co.uk/sounds/play/*'],
js: ['connectors/bbc-sounds.js'],
}, {
label: 'Gaana',
matches: ['*://gaana.com/*'],
Expand Down

3 comments on commit 832ec5a

@FTT2004
Copy link

@FTT2004 FTT2004 commented on 832ec5a Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi alexesprit, I hope I am in the right place to provide an update. Thanks for fixing this issue in 2019. I am now using Brave Browser and the Shields Up function interferes with the extension. A workaround I have found is to toggle off Shields Off, let the songs play and click on the extension icon a few times. Then I toggled Shields Up and the extension continued to work!! Keep up the amazing work!!

@alexesprit
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FTT2004! Thank you for the kind words!

What is Shields Up?

@FTT2004
Copy link

@FTT2004 FTT2004 commented on 832ec5a Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a feature of brave browser that seeks to block tracking features.

Please sign in to comment.