Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filters #1552

Closed
OwnageIsMagic opened this issue Jan 7, 2018 · 16 comments · Fixed by #3671
Closed

Custom filters #1552

OwnageIsMagic opened this issue Jan 7, 2018 · 16 comments · Fixed by #3671
Labels
core This issue or pull request is related to the extension core feature New feature or request

Comments

@OwnageIsMagic
Copy link
Contributor

Add user created fillters

@alexesprit
Copy link
Member

What do you mean by filters?

@OwnageIsMagic
Copy link
Contributor Author

OwnageIsMagic commented Jan 7, 2018

Metadata filters
https://www.youtube.com/watch?v=MBvAvW6KQDk&list=PLRO4b8EqD8g5ptqAPiMnrnslZPIK70V44&index=7
have all songs ending wih - Solo Guitar
I want to remove it

@alexesprit alexesprit added core This issue or pull request is related to the extension core feature New feature or request labels Jan 7, 2018
@alexesprit
Copy link
Member

But this feature is related to Youtube connector only, right? Because other connectors (excepts several ones) use other filters.

@OwnageIsMagic
Copy link
Contributor Author

The best approach is to be able to configure used filters dynamically

@OwnageIsMagic
Copy link
Contributor Author

Something with checkboxes where I can enable each filter individually or disable all post processing

@alexesprit
Copy link
Member

Do you suggest to apply these user-defined rules (because a filter is an object) to every connector?

Now we have the default trim filter used everywhere, plus, some connectors extend this filter by other custom filters. Your suggestion is to add another filter which uses custom rules defined by a user. Am I correct?

@OwnageIsMagic
Copy link
Contributor Author

image
Something like this
user defines custom function that accepts metadata, mutates it and returns it

@OwnageIsMagic
Copy link
Contributor Author

Solve this type of problems:

Implement translit filter (for bandcamp) and enable it only on for current album

And make it Promise based to allow async operations :)

@OwnageIsMagic
Copy link
Contributor Author

btw there are tons of filters that I would like to apply and they are already implemented for others controllers but it requires plugin rebuild to enable them
for example
image

@inverse
Copy link
Member

inverse commented Jan 28, 2018

So is this really a two part feature.

  • Add support for custom user defined filters
  • A rule engine to decide when to apply. e.g.
    • Current album
    • Connector
    • Page?

@OwnageIsMagic
Copy link
Contributor Author

Yes and no
With custom filter I can copypaste all needed filters to all-in-one
But design like this looks more user friendly
image
Dropdown with connectors
On the left all filters, on the right applied

@brodie-g
Copy link
Contributor

If I'm understanding this feature correctly, it might help with an issue I'm having.

Scrobbling from SiriusXM web app, there's a lot of tracks that are appended by the year in brackets:

Diamonds - The Stroll (57)
Petula Clark - I Know A Place (65)

Is there anything that exists now, or would the filter feature be able to strip out text? In this case, a regex to find and remove numbers in parentheses at the end of the track title before submitting to last.fm.

@sorashi
Copy link

sorashi commented Jan 21, 2019

I would like something similar to this to be implemented, because there are YouTube song titles ending with | Some Genre and they fail to be recognized correctly. I would like the option to make custom regex filters.

@RAM237
Copy link

RAM237 commented Nov 15, 2019

Agree, guys, would be really helpful and time-saving in some specific cases.

@litiaikin
Copy link

Would be nice to have the ability to automatically apply custom user defined regex filters to album name and track title before submitting data to LastFM.

@kimonoki
Copy link
Contributor

Yes would nice to have something like pano scrobbler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue or pull request is related to the extension core feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants