Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to automatically convert latest comma in artists field into ampersand #2608

Closed
sc113 opened this issue Oct 24, 2020 · 6 comments · Fixed by #3671
Closed

Option to automatically convert latest comma in artists field into ampersand #2608

sc113 opened this issue Oct 24, 2020 · 6 comments · Fixed by #3671
Labels
feature New feature or request

Comments

@sc113
Copy link

sc113 commented Oct 24, 2020

I.e. scan artist field for the rightmost ", " and replace it to " & " automatically.

It would help in converting spotify\deezer tags into last.fm standards automatically, that I usually do manually.

@sc113 sc113 added the feature New feature or request label Oct 24, 2020
@inverse
Copy link
Member

inverse commented Oct 25, 2020

Sound related to #1552

@alexesprit
Copy link
Member

Not sure if it's related to #1552.

I think this could be resolved by using a global transformation enabled by default for all websites.

AFAIK, the most common format is Artist — Track (feat. Artist 2, Artist 3, ...), whereas Spotify uses Artist, Artist 2, Artist 3 — Track or even Artist, Artist 2, Artist 3 — Track (feat. Artist 2, Artist 3, ...).

@alexesprit
Copy link
Member

By the way, we can just search for comma in the artist field directly: some artist names contain comma, e.g. "Time, The Valuator", "Invent, Animate".

Spotify (and some other websites) uses different DOM elements for each artist, so we can get an array of artist names from such websites. Using an array instead of a raw string to transform track info is much robust.

@sc113
Copy link
Author

sc113 commented Nov 25, 2020

Yeah, that would be much better, and probably could be implemented for all the major streaming services.
Things would be quite less complicated, if last.fm moved towards implementing multiply artists for single scrobble. There is discussion started on that on last.fm forums, but unfortunately without any reaction from last.fm stuff so far.

@alexesprit
Copy link
Member

alexesprit commented Jan 27, 2021

Spotify (and some other websites) uses different DOM elements for each artist, so we can get an array of artist names from such websites. Using an array instead of a raw string to transform track info is much robust.

We use MediaSession API for Spotify and other websites, and this API does not support multiple artists. The data received via API has a higher priority over data from DOM, so we should handle this somehow too.

I think we can keep the MediaSession vs DOM priority unchanged, but prioritize array of multiple artists from DOM over artist as a string from MediaSession metadata.

@sc113
Copy link
Author

sc113 commented Aug 24, 2021

Just bumping, as still hoping for an option to separate the last artist with an ampersand. I'm getting bloody tired of adding "&" to every track on Spotify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants