Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xiami's design changed #1817

Closed
cptchi opened this issue Dec 1, 2018 · 9 comments
Closed

Xiami's design changed #1817

cptchi opened this issue Dec 1, 2018 · 9 comments
Assignees
@alexesprit
Labels
bug Something isn't working connector This issue or pull request is related to connectors

Comments

@cptchi
Copy link

cptchi commented Dec 1, 2018

Hi, Xiami just went through a huge redesign and the player isn't on a different tab anymore, so the scrobbler isn't working.
@KwonDae KwonDae mentioned this issue Dec 1, 2018
Closed
@KwonDae
Copy link
Contributor

KwonDae commented Dec 1, 2018

#1818
I changed some code about Xiami.
please check my codes and If there's anything wrong, I'd appreciate it if you let me know.

@inverse inverse added bug Something isn't working connector This issue or pull request is related to connectors labels Dec 3, 2018
@KwonDae KwonDae mentioned this issue Dec 30, 2018
Merged
@cptchi cptchi mentioned this issue Jan 16, 2019
Closed
3 tasks
inverse pushed a commit that referenced this issue Jan 22, 2019
@KwonDae @inverse
Issue #1817 Xiami scrobbler error fixed (#1848)
25ade70 
* modify xiami

* delete package-lock

* error fixed

* add getDuration

* modify singlequote

* add endline of xiami.js

* remove unexpected newLine

* drop the playButtonSelector

* change duration part

* add UniqueId
@fanmuxxx
Copy link

Hi, I know this has been brought up a few weeks ago. However, my scrobbler doesn't work on xiami in the recent 3 days, and it was totally OK last week. Could someone please have a test and let me know?

@inverse
Copy link
Member

inverse commented Jan 29, 2019

@KwonDae any input on this?

@KwonDae
Copy link
Contributor

KwonDae commented Jan 29, 2019

No, i haven't. Is there any problem in xiami.com?

@fanmuxxx
Copy link

please see my last comment. My scrobbler doesn't work on https://www.xiami.com/play page

@KwonDae
Copy link
Contributor

KwonDae commented Jan 30, 2019

Because xiami.com/play was changed to xiami.com.
xiami.com/play doesn't supported until page updated.

@cptchi
Copy link
Author

cptchi commented Jan 30, 2019

fanmuxx, xiami got a new design and therefore the old scrobbler didn't work on it
if you haven't been redirected to it, click the little home icon on the bottom right corner of the xiami page
new xiami

@fanmuxxx
Copy link

@KwonDae @cptchi Thank both for your help. It works for me now.

I preferred the old design but I suppose that now I have to switch to the new version for the scrobbler function.

@inverse
Copy link
Member

inverse commented Jan 31, 2019

The extension can be made to work with both designs. you just need a way to detect the design and wire up the behavior accordingly.

@alexesprit alexesprit added the help wanted Extra attention is needed label Jun 12, 2019
@alexesprit alexesprit mentioned this issue Jun 12, 2019
Closed
3 tasks
@alexesprit alexesprit removed the help wanted Extra attention is needed label Jun 12, 2019
@alexesprit alexesprit self-assigned this Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexesprit alexesprit

Labels
bug Something isn't working connector This issue or pull request is related to connectors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@inverse @alexesprit @KwonDae @cptchi @fanmuxxx