Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide option to disable scrobbling podcasts on Google Music. #1773

Merged
merged 1 commit into from Oct 30, 2018
Merged

Provide option to disable scrobbling podcasts on Google Music. #1773

merged 1 commit into from Oct 30, 2018

Conversation

jaccarmac
Copy link
Contributor

No description provided.

@jaccarmac
Copy link
Contributor Author

jaccarmac commented Oct 29, 2018 •
edited

A couple things aren't working quite yet and I'd like suggestions on how to get them in shape for a merge.

  • Internationalization doesn't seem to be working. Do I need to add the entries to all four language files?
  • The option doesn't have a default value set and it looks like connector-specific options have defaults set-up yet. Shall I add a similar hook to initialize those?

@inverse
Copy link
Member

inverse commented Oct 29, 2018

Awesome!

  • It looks like point one is working for me. I've got en as my locale and it's displaying correctly.
  • Having some sane default sounds like a good idea - not sure where this would make the most sense.

@jaccarmac
Copy link
Contributor Author

Locale was indeed some kind of caching issue. Latest commit should be ready for merge once Travis decides it's linted well enough.

@inverse inverse merged commit 65a0c82 into web-scrobbler:master Oct 30, 2018
@inverse
Copy link
Member

inverse commented Oct 30, 2018

Super! Thanks for the contribution :)

@jaccarmac jaccarmac deleted the google-play-music-podcasts branch October 30, 2018 15:50
@alexesprit alexesprit added connector This issue or pull request is related to connectors feature New feature or request labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
connector This issue or pull request is related to connectors feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaccarmac @inverse @alexesprit