-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #1809 Jamendo scrobbler error fixed #1811
Conversation
I had a conflicts in radioparadise.js because I was trying to solve the problems that had been occured before. I rolled it back to the one before. Jamendo site error is fixed now. For the issue #1809 Thanks:) |
|
||
Connector.trackArtSelector = '.js-full-player-cover-img'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't changing this selector to .hero-cover img
be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That also works. I tried to get a "src" from image. I guess both works.
What do you prefer more? If you prefer that one more, please tell me. I will take it over.
I tried what you said, and compiled it in my local laptop. And it works too. I just changed it into that code, and sent you a PR again. Please check! Thanks:) |
Thanks! |
Issue #1809 Jamendo scrobbler error fixed
Issue #1809
Play button and TrackArt were not working.
So, I fixed it like this:
Connector.isPlaying = () => {
return $('.js-player-play-pause > .icon-pause').length !== 0;
};
Connector.getTrackArt = () => {${$ ('.hero-cover').find('img').attr('src')};
return
};
I compiled it in my local pc, and it works now.
Thanks:)