monkey3 connector done #1813
Merged
monkey3 connector done #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inverse
requested changes
Nov 27, 2018
src/connectors/monkey3.js
Outdated
| }; | ||
|
|
||
| Connector.getTrackArt = () => { | ||
| return $('.albumview .cover .img').find('img').attr('src'); |
There was a problem hiding this comment.
This could be simplified to use the trackArtSelector and just make it equal .albumview .cover .img
src/core/connectors.js
Outdated
| @@ -733,6 +733,12 @@ define(function() { | |||
| js: ['connectors/bugs.js'], | |||
| }, | |||
|
|
|||
| { | |||
| label: 'monkey3', | |||
| matches: ['*://www.monkey3.co.kr*'], | |||
There was a problem hiding this comment.
Is this correct? shouldn't it be like?
Suggested change
| matches: ['*://www.monkey3.co.kr*'], | |
| matches: ['*://www.monkey3.co.kr/*'], |
|
I saw your recommendations and i modified that parts as you talked. |
alexesprit
added
connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Monkey3 Player`s connector.
This is one the famous music player in South Korea.
I like this Website!