-
-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added radiojavan connector. #2032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome first attempt. Unsure about the playButtonSelector though.
Also var
should be replaces with let
See the travis build status for info.
|
||
Connector.trackSelector = '.mainPanel .song'; | ||
|
||
Connector.playButtonSelector = '.playIcon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be dropped as you've wired up the Connector.isPlaying
function. Alternatively and perhaps better is what @alexesprit suggested and to drop Connector.isPlaying and wire up the
stopButtonSelector` After that It's all good
@Slayer0248 any update? |
The connector does not work properly because of bugged website. It's partially reloaded on every track change (including The solution is to use custom mutation observer to watch the whole document: new MutationObserver(Connector.onStateChanged).observe(document, {
childList: true, subtree: true,
attributes: true, characterData: true,
}); |
Added radiojavan connector.