Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for abc.com.au #2439

Merged
merged 9 commits into from
Jun 9, 2020
Merged

Conversation

inverse
Copy link
Member

@inverse inverse commented Jun 5, 2020

Resolves #2436

Supports all 3 players on the page.

@alexesprit
Copy link
Member

Could you not use jQuery?

src/core/connectors.js Outdated Show resolved Hide resolved
@alexesprit alexesprit added connector This issue or pull request is related to connectors implemented This pull request proposes a new connector implemented labels Jun 6, 2020
@inverse
Copy link
Member Author

inverse commented Jun 6, 2020

When did you deprecate support and why?

@alexesprit
Copy link
Member

When did you deprecate support and why?

https://github.com/web-scrobbler/web-scrobbler/wiki/Connector-API-changes#v2310

It was mostly used along with Bootstrap, but jQuery will be removed in Bootstrap 5. So, there's no sense to keep a dependency, when we can do everything with DOM API.

Using jQuery in connectors to get a text from an element is overkill.

@inverse
Copy link
Member Author

inverse commented Jun 6, 2020

Why reducing the number of 3rd party dependencies can be a good thing I think leveraging something as well known as jQuery aids the barrier to entry for people to contribute. Although I know vanilla JS has come on a long way.

@inverse inverse changed the title Add support for Triplej Add support for abc.com.au Jun 6, 2020
@inverse
Copy link
Member Author

inverse commented Jun 6, 2020

What's wierd is the triplej player now for me isnt' expanding with track info

image

The other two are just fine - but they have different selectors

Copy link
Member

@alexesprit alexesprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexesprit alexesprit merged commit 744e6d6 into web-scrobbler:master Jun 9, 2020
@inverse inverse deleted the triplej branch November 11, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector This issue or pull request is related to connectors implemented This pull request proposes a new connector implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Triple J to list of supported websites
2 participants