-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for abc.com.au #2439
Conversation
Could you not use jQuery? |
When did you deprecate support and why? |
https://github.com/web-scrobbler/web-scrobbler/wiki/Connector-API-changes#v2310 It was mostly used along with Bootstrap, but jQuery will be removed in Bootstrap 5. So, there's no sense to keep a dependency, when we can do everything with DOM API. Using jQuery in connectors to get a text from an element is overkill. |
Why reducing the number of 3rd party dependencies can be a good thing I think leveraging something as well known as jQuery aids the barrier to entry for people to contribute. Although I know vanilla JS has come on a long way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Resolves #2436
Supports all 3 players on the page.