Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JQBX connector #2444

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Added JQBX connector #2444

merged 3 commits into from
Jun 9, 2020

Conversation

daniel-stoneuk
Copy link
Contributor

Describe the changes you made
Added a connector for JQBX.

For use at *://app.jqbx.com

Let me know if you would rather the connector to be named without the app lower level domain.

@alexesprit
Copy link
Member

Let me know if you would rather the connector to be named without the app lower level domain.

If there are no other subdomains on jqbx.com, the app suffix can be omitted.

@alexesprit alexesprit added connector This issue or pull request is related to connectors implemented This pull request proposes a new connector implemented labels Jun 8, 2020
@daniel-stoneuk
Copy link
Contributor Author

Brilliant - wasn't too sure. Thanks.

alexesprit
alexesprit approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@alexesprit alexesprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't verify - the website is not available for me. I belive it works fine. :) Thanks for contributing.

@alexesprit alexesprit merged commit 7bdcdca into web-scrobbler:master Jun 9, 2020
@daniel-stoneuk
Copy link
Contributor Author

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexesprit alexesprit alexesprit approved these changes

Assignees
No one assigned
Labels
connector This issue or pull request is related to connectors implemented This pull request proposes a new connector implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-stoneuk @alexesprit