-
-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow youtube connector to get data from Youtube Music #3526
Conversation
This option allows you to only scroble music recognised by youtube music as a music video. Only added locales for english.
Looks interesting. I can see a few potential issues, but I need to spin it up to confirm, I think I should have a bit of time tomorrow. I can also see that this getter should definitely be disableable in settings. |
As requested, added an option to disable the getter, it works independently from the option to only scrobble if yt music detects it as a music video. So the behaviour is as follows: Both options enabled or only the getter enabled: Only 'scrobbleMusicRecognisedOnly' enabled: Neither option is enabled: |
Specifically the getter that uses youtube music, when musicVideoType is undefined, no error will be thrown and a generic catch is added.
Hi, do you want to add some of the extra logic that you added later on added to this PR before it is merged, or do you want it to be merged as is? |
I can't really add the extra logic as that's all about returning multiple possibilities for matches which isn't useful for this project (yet?), so it can be merged as is! |
Describe the changes you made
Add a track info getter that uses youtube music to get its information. This information seems to be more reliable than the info in the description. Downside is that this getter has to make a request, which takes a bit, so there's a bit more delay before the scrobbler finds the information. It does cache all requests it has made already, so this is only the first time, as long as the user doesn't restart their browser.
At least in my experience this getter seems to me more reliable than the ones based on description/title, but I'm not sure how to verify this as it might depend greatly on the type of music you listen to. It's not perfect regrettably, for example it might swap names around compared to the most common value in Last.fm, eg. "Fireboy DML & Asake" becomes "Asake & Fireboy DML".
I also added an option to only scrobble videos that are recognised by yt music as a music video, which seems to work quite well.
I can only write in English so someone else will have to translate this option to the other locales.