Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @web-scrobbler/metadata-filter #3621

Merged
merged 6 commits into from Apr 5, 2023

Conversation

inverse
Copy link
Member

@inverse inverse commented Apr 3, 2023

Describe the changes you made

V3 is a release of v2 under the new org and as such removed a lot of deprecated functions.

Release notes: https://github.com/web-scrobbler/metadata-filter/releases/tag/v2.0.0

Additional context

@inverse inverse marked this pull request as draft April 3, 2023 21:32
@inverse inverse added maintenance Improvements or additions to maintenance patch-change For patch changes labels Apr 4, 2023
@inverse inverse marked this pull request as ready for review April 4, 2023 20:51
@inverse
Copy link
Member Author

inverse commented Apr 4, 2023

For some reason the popup isn't showing with this change for me and I am not sure why :/

@yayuyokitano
Copy link
Member

For some reason the popup isn't showing with this change for me and I am not sure why :/

inverse#128 fixes this

@inverse
Copy link
Member Author

inverse commented Apr 5, 2023

Thanks @yayuyokitano

@inverse inverse merged commit e30f91f into web-scrobbler:master Apr 5, 2023
6 checks passed
@inverse inverse deleted the upgrade-metadata-filter branch April 5, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements or additions to maintenance patch-change For patch changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants