Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemaps in dev mode #3622

Merged
merged 1 commit into from Apr 5, 2023
Merged

Conversation

inverse
Copy link
Member

@inverse inverse commented Apr 4, 2023

Describe the changes you made

Provide easier debugging in dev mode with sourcemap output

Additional context

@inverse inverse added maintenance Improvements or additions to maintenance patch-change For patch changes labels Apr 4, 2023
Copy link
Member

@yayuyokitano yayuyokitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this does remind me that the connectors are always compiled with source maps. We probably want to change that too soon. A bit more complex since connectors are just based on the tsconfig.connectors.json file, which we cannot set dynamic values in, but nothing too complicated.

@inverse inverse merged commit a50e66d into web-scrobbler:master Apr 5, 2023
8 checks passed
@inverse inverse deleted the add-sourcemaps branch November 11, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improvements or additions to maintenance patch-change For patch changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants