Fix Connector API handling of undefined/null values #3689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayuyokitano
added
core
inverse
reviewed
May 2, 2023
inverse
reviewed
May 2, 2023
inverse
reviewed
May 3, 2023
| @@ -307,7 +307,9 @@ export default class BaseConnector { | |||
| * @param trackArtUrl - Track art URL | |||
| * @returns Check result | |||
| */ | |||
| public isTrackArtDefault: (trackArtUrl?: string) => boolean = () => false; | |||
| public isTrackArtDefault: ( | |||
There was a problem hiding this comment.
Do we really want to do this? Feels like this function should always return bool
inverse
reviewed
May 3, 2023
inverse
approved these changes
May 3, 2023
|
Yeah it's a little odd – why i didn't do this in the initial v3 implementation. btw I wonder if we're good to release now. I can't think of anything more at this point (though im sure there are some bugs hiding) |
|
Feels like we're in a very good shape with a lot of nice additions from you ;) Pushed the latest translations - should probably look into syncing those automatically but we're in a good place right now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions in connector do not handle undefined/null values correctly.
This goes a long way to fixing that, and adjusts connectors accordingly.
I think once these three current PRs are merged, I want to do one last PR changing the sidebar organization in the options (I think there will be a lot of merge conflicts if this is done before current PRs are merged and I can't be bothered) and then I think we might be ready to release!