Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit import/exports #3698

Merged
merged 3 commits into from May 5, 2023
Merged

Fix edit import/exports #3698

merged 3 commits into from May 5, 2023

Conversation

yayuyokitano
Copy link
Member

  • Changes the export method to be compatible with safari.
  • Moves to using refs for imports, fixing an accidental ID-related bug in the process.
  • Live updates the content of the modals to show imported edits without refreshing the page.

@yayuyokitano yayuyokitano added core This issue or pull request is related to the extension core fixed labels May 5, 2023
Copy link
Member

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yayuyokitano yayuyokitano merged commit 1bc199b into web-scrobbler:master May 5, 2023
10 checks passed
@yayuyokitano yayuyokitano deleted the safaridl branch May 8, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This issue or pull request is related to the extension core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants